forked from box/mojito
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(security): Update AuthenticatedRestTemplate #202
Open
byronantak
wants to merge
5
commits into
master
Choose a base branch
from
feat/authenticated-rest-template
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
byronantak
commented
Nov 27, 2024
•
edited
Loading
edited
- Create service to check if the proxy is health
- It only does a proxy health check only on start-up
- Add unit tests for the service
- Add more debug logs to help identify which auth flows were taken
- Add missing exception case for final CSRF request
- it used to fail silently before if a non 200 response was received
- Create Proxy interceptor
- Only go through the proxy if the proxy is healthy
byronantak
force-pushed
the
feat/authenticated-rest-template
branch
8 times, most recently
from
December 2, 2024 11:18
1b8fdc8
to
da78ae3
Compare
byronantak
force-pushed
the
feat/authenticated-rest-template
branch
from
December 2, 2024 13:56
da78ae3
to
0415d4e
Compare
byronantak
force-pushed
the
feat/authenticated-rest-template
branch
from
December 2, 2024 14:46
0415d4e
to
1a6beff
Compare
maallen
reviewed
Dec 3, 2024
...main/java/com/box/l10n/mojito/rest/resttemplate/LoginAuthenticationCsrfTokenInterceptor.java
Outdated
Show resolved
Hide resolved
restclient/src/main/java/com/box/l10n/mojito/rest/resttemplate/AuthenticatedRestTemplate.java
Outdated
Show resolved
Hide resolved
...main/java/com/box/l10n/mojito/rest/resttemplate/LoginAuthenticationCsrfTokenInterceptor.java
Outdated
Show resolved
Hide resolved
...main/java/com/box/l10n/mojito/rest/resttemplate/LoginAuthenticationCsrfTokenInterceptor.java
Outdated
Show resolved
Hide resolved
...main/java/com/box/l10n/mojito/rest/resttemplate/LoginAuthenticationCsrfTokenInterceptor.java
Outdated
Show resolved
Hide resolved
restclient/src/main/java/com/box/l10n/mojito/rest/resttemplate/ProxyHealthCheckService.java
Show resolved
Hide resolved
...ent/src/main/java/com/box/l10n/mojito/rest/resttemplate/ProxyOutboundRequestInterceptor.java
Show resolved
Hide resolved
maallen
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.